feat(webapp,run-engine,core,clickhouse): surface combined concurrency in metrics and dashboard by matt-aitken · Pull Request #4830 · triggerdotdev/trigger.dev

matt-aitken · 2026-08-29T12:27:51Z

Summary

Queues with a combinedConcurrencyLimit now show how they use it, in the dashboard and the API. Stacked on #4829.

The queues list gains a Total column showing runs in flight across all concurrency keys against the queue's total cap, turning warning-colored when the cap is reached. The queue detail page gains a "Total concurrency" chart plotting total running against the effective cap over time, and the per-key table gains a Limit column that shows each key's effective concurrency limit, highlighting keys with a per-key override. Queue retrieve and list API responses include the same totals under concurrency.combined.

Design

The queue metrics gauge (emitted from the dequeue and enqueue Lua scripts) is extended with two fields: total running (the group concurrency set's cardinality) and the raw stored total limit. They flow through the existing metrics stream into the ClickHouse raw table and are aggregated as max_total_running / max_total_limit in the 10s and 5m rollup tiers, queryable from the dashboard's TRQL widgets. The per-key rollup additionally records each key's effective limit so overrides are visible historically.

Reading the live numbers is O(pages shown): the list presenter batches one SCARD per queue that has a cap, and the per-key table reads the queue's override hash once per page.

changeset-bot · 2026-08-29T12:27:56Z

🦋 Changeset detected

Latest commit: 2e78efd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages

Name	Type
@trigger.dev/core	Patch
@trigger.dev/build	Patch
trigger.dev	Patch
@trigger.dev/python	Patch
@trigger.dev/redis-worker	Patch
@trigger.dev/schema-to-json	Patch
@trigger.dev/sdk	Patch
@internal/clickhouse	Patch
@internal/llm-model-catalog	Patch
@internal/metrics-pipeline	Patch
@trigger.dev/rbac	Patch
@internal/redis	Patch
@internal/replication	Patch
@internal/run-engine	Patch
@internal/run-store	Patch
@internal/schedule-engine	Patch
@internal/tracing	Patch
@internal/webhook-engine	Patch
@internal/webhook-sources	Patch
@internal/dashboard-agent	Patch
@internal/cache	Patch
@trigger.dev/react-hooks	Patch
@trigger.dev/rsc	Patch
@trigger.dev/database	Patch
@trigger.dev/otlp-importer	Patch
@trigger.dev/sso	Patch
@internal/testcontainers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-08-29T12:27:58Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2ed366dd-7103-4129-abbc-0842fcc6e97f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

devin-ai-integration

Note

This report is out of date. Scroll down for Devin Review's latest report on this PR.

Devin Review found 0 new potential issues.

pkg-pr-new · 2026-08-29T14:52:20Z

Open in StackBlitz

@trigger.dev/build

npm i https://pkg.pr.new/@trigger.dev/build@ecfbdbb

trigger.dev

npm i https://pkg.pr.new/trigger.dev@ecfbdbb

@trigger.dev/core

npm i https://pkg.pr.new/@trigger.dev/core@ecfbdbb

@trigger.dev/python

npm i https://pkg.pr.new/@trigger.dev/python@ecfbdbb

@trigger.dev/react-hooks

npm i https://pkg.pr.new/@trigger.dev/react-hooks@ecfbdbb

@trigger.dev/redis-worker

npm i https://pkg.pr.new/@trigger.dev/redis-worker@ecfbdbb

@trigger.dev/rsc

npm i https://pkg.pr.new/@trigger.dev/rsc@ecfbdbb

@trigger.dev/schema-to-json

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@ecfbdbb

@trigger.dev/sdk

npm i https://pkg.pr.new/@trigger.dev/sdk@ecfbdbb

commit: ecfbdbb

devin-ai-integration

Note

This report is out of date. Scroll down for Devin Review's latest report on this PR.

Devin Review found 0 new potential issues.

devin-ai-integration

Note

This report is out of date. Scroll down for Devin Review's latest report on this PR.

Devin Review found 0 new potential issues.

devin-ai-integration

Note

This report is out of date. Scroll down for Devin Review's latest report on this PR.

Devin Review found 0 new potential issues.

devin-ai-integration

Note

This report is out of date. Scroll down for Devin Review's latest report on this PR.

Devin Review found 0 new potential issues.

… metrics and dashboard Queues with a totalConcurrencyLimit now report how they use it. The gauge pipeline emits total running and the stored cap, ClickHouse aggregates them into the queue metrics tiers, the queues list gets a Total column, the queue detail page charts total running against the cap, and the per-key table shows each key's effective limit including per-key overrides. Queue retrieve and list API responses include the same totals.

…tore views on rollback The CK enqueue gauges (fast path and queued path) now sample total running and the stored cap, so metric buckets fed only by enqueues no longer record zero totals. The migration's down section recreates the pre-existing materialized view definitions so ingestion keeps flowing after a rollback. The per-key table reads only the page's overrides with one HMGET instead of loading the queue's whole override hash.

The test harness splits a migration's up section on semicolons, so a semicolon inside a comment yields a comment-only statement that ClickHouse rejects as an empty query and every container-backed suite fails at setup.

Queue retrieve only asks the engine for total running when a total limit is set, matching the list presenter and avoiding a pointless read for the common uncapped case.

The total concurrency numbers come from live Redis, not the metrics pipeline, so the column belongs in both tables rather than only behind the queue metrics UI gate.

A separate Total column implied every queue should have one, and its dash read as a missing limit on queues that never use concurrency keys. Only queues that declare a totalConcurrencyLimit now change: their Limit cell reads as per-key plus total (e.g. 1 /key, 3 total) and Running turns warning-colored when the total cap is saturated. Plain queues are unchanged.

The total cap gates keyed admissions, so the Running cell now warns off the group count rather than the aggregate that also includes unkeyed runs.

…dashboard and metrics Queue API responses expose concurrency.combined, the dashboard says combined, and the new metrics columns are named combined_running and combined_limit.

Queues that set a combinedConcurrencyLimit show it bracketed next to the per-key limit with a fine dashed underline and an explanatory tooltip; the Limit header tooltip is width-capped. Queues without one are unchanged.

The tooltip trigger is a button, so nesting it in the Limit cell's link made clicking it navigate; it now renders as the cell's trailing adornment.

devin-ai-integration

Devin Review found 0 new potential issues.

This comment was marked as resolved.

Sign in to view

devin-ai-integration Bot reviewed Aug 29, 2026

View reviewed changes

matt-aitken force-pushed the feat/queue-concurrency-metrics branch from 8f5ad5d to c60df90 Compare August 29, 2026 14:49

matt-aitken force-pushed the feat/queue-concurrency-metrics branch from c60df90 to 2816d30 Compare August 29, 2026 15:33

devin-ai-integration Bot reviewed Aug 29, 2026

View reviewed changes

matt-aitken force-pushed the feat/queue-concurrency-metrics branch from fe6772f to 6bc8bef Compare August 29, 2026 15:52

devin-ai-integration Bot reviewed Aug 29, 2026

View reviewed changes

This comment was marked as resolved.

Sign in to view

devin-ai-integration Bot reviewed Aug 29, 2026

View reviewed changes

matt-aitken force-pushed the feat/queue-concurrency-metrics branch from e802dab to 1627de4 Compare August 29, 2026 18:11

matt-aitken changed the title ~~feat(webapp,run-engine,core,clickhouse): surface total concurrency in metrics and dashboard~~ feat(webapp,run-engine,core,clickhouse): surface combined concurrency in metrics and dashboard Aug 29, 2026

This comment was marked as resolved.

Sign in to view

matt-aitken force-pushed the feat/queue-concurrency-metrics branch from 1627de4 to f4b8109 Compare August 29, 2026 18:18

matt-aitken added 8 commits August 29, 2026 19:20

fix(clickhouse): keep migration comments semicolon-free

a008108

The test harness splits a migration's up section on semicolons, so a semicolon inside a comment yields a comment-only statement that ClickHouse rejects as an empty query and every container-backed suite fails at setup.

fix(webapp): skip the total concurrency read when the queue has no cap

03146bf

Queue retrieve only asks the engine for total running when a total limit is set, matching the list presenter and avoiding a pointless read for the common uncapped case.

feat(webapp): show the Total column in the non-metrics queues table too

a6eb24e

The total concurrency numbers come from live Redis, not the metrics pipeline, so the column belongs in both tables rather than only behind the queue metrics UI gate.

fix(webapp): saturate the total-cap warning on keyed runs only

7dc9c8a

The total cap gates keyed admissions, so the Running cell now warns off the group count rather than the aggregate that also includes unkeyed runs.

refactor(webapp,core,clickhouse): combined concurrency in responses, …

ecfbdbb

…dashboard and metrics Queue API responses expose concurrency.combined, the dashboard says combined, and the new metrics columns are named combined_running and combined_limit.

matt-aitken force-pushed the feat/queue-concurrency-metrics branch from f4b8109 to ecfbdbb Compare August 29, 2026 18:21

feat(webapp): bracketed combined limit in the Limit column

3fb8f96

Queues that set a combinedConcurrencyLimit show it bracketed next to the per-key limit with a fine dashed underline and an explanatory tooltip; the Limit header tooltip is width-capped. Queues without one are unchanged.

This comment was marked as resolved.

Sign in to view

fix(webapp): combined-limit tooltip renders beside the cell link

2e78efd

The tooltip trigger is a button, so nesting it in the Limit cell's link made clicking it navigate; it now renders as the cell's trailing adornment.

devin-ai-integration Bot reviewed Aug 29, 2026

View reviewed changes

Uh oh!

Uh oh!

Conversation

matt-aitken commented Aug 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Design

Uh oh!

changeset-bot Bot commented Aug 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Aug 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

This comment was marked as resolved.

Uh oh!

devin-ai-integration Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pkg-pr-new Bot commented Aug 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

devin-ai-integration Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

matt-aitken commented Aug 29, 2026 •

edited

Loading

changeset-bot Bot commented Aug 29, 2026 •

edited

Loading

coderabbitai Bot commented Aug 29, 2026 •

edited

Loading

devin-ai-integration Bot left a comment •

edited

Loading

pkg-pr-new Bot commented Aug 29, 2026 •

edited

Loading

devin-ai-integration Bot left a comment •

edited

Loading

devin-ai-integration Bot left a comment •

edited

Loading

devin-ai-integration Bot left a comment •

edited

Loading

devin-ai-integration Bot left a comment •

edited

Loading